[stdlib] Replacing M_PI with .pi #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please smoke test and merge |
| @@ -124,7 +124,7 @@ public struct AffineTransform : ReferenceConvertible, Hashable, CustomStringConv | |||
| [ 0 0 1 ] | |||
| */ | |||
| public init(rotationByDegrees angle: CGFloat) { | |||
| let α = Double(angle) * M_PI / 180.0 | |||
| let α = Double(angle) * .pi / 180.0 | |||
| self.init(rotationByRadians: CGFloat(α)) | |||
There was a problem hiding this comment.
These could be cleaned up further, I think; there's no long any need for the conversions.
self.init(rotationByRadians: angle * .pi / 180)
Possibly outside the scope of this change.
There was a problem hiding this comment.
Oh. right! CGFloat conforms to the same protocol. Makes perfect sense. Thanks!
| @@ -169,19 +169,19 @@ class TestAffineTransform : TestAffineTransformSuper { | |||
| checkPointTransformation(noop, point: point, expectedPoint: point) | |||
|
|
|||
| var tenEighty = AffineTransform.identity | |||
| tenEighty.rotate(byRadians: CGFloat(6 * M_PI)) | |||
| tenEighty.rotate(byRadians: CGFloat(6 * Double.pi)) | |||
There was a problem hiding this comment.
Similarly, these could just be tenEighty.rotate(byRadians: 6 * .pi).
ghost
mentioned this pull request
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M_PIhas recently been deprecated. Replacing it's usages to avoid compilation warnings.