Coalesce protocol conformance sections on FreeBSD. #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # conformance sections. This wouldn't be necessary if the link was done by | ||
| # the swift binary: rdar://problem/19007002 | ||
| if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" OR | ||
| "${CMAKE_SYSTEM_NAME}" STREQUAL "FreeBSD") |
There was a problem hiding this comment.
The continuation line should align with the if( line:
if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" OR
"${CMAKE_SYSTEM_NAME}" STREQUAL "FreeBSD")
|
@dcci LGTM, just a small indentation issue. Please fix and I'll merge. |
gribozavr
added a commit
that referenced
this pull request
Dec 13, 2015
Coalesce protocol conformance sections on FreeBSD.
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
add swift cluster membership
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows swiftc compiled binaries to run correctly on FreeBSD.
% ./swiftc hello.swift -o hello
davide@rabbit1:/exps/swift/build/Ninja-ReleaseAssert/swift-freebsd-x86_64/bin
% ./hello
hello
% cat hello.swift
print ("hello")
Special thanks to Dmitri Gribenko who provided help debugging the issue