-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable swift docc tests #41839
Re-enable swift docc tests #41839
Conversation
Please test with following pull request: @swift-ci Please test |
Please test with following pull request: @swift-ci Please Build Toolchain |
swiftlang/swift-docc#101 |
@swift-ci Please test |
@swift-ci Please Build Toolchain |
swiftlang/swift-docc#101 |
swiftlang/swift-docc#101 |
swiftlang/swift-docc#101 |
1 similar comment
swiftlang/swift-docc#101 |
@swift-ci Please Build Toolchain Linux Platform |
@swift-ci Please Build Toolchain macOS Platform |
swiftlang/swift-docc#101 |
3 similar comments
swiftlang/swift-docc#101 |
swiftlang/swift-docc#101 |
swiftlang/swift-docc#101 |
swiftlang/swift-docc#101 |
@swift-ci Please test |
@swift-ci Please Build Toolchain |
@swift-ci Please smoke test |
@swift-ci Please test |
@swift-ci Please Build Toolchain |
@swift-ci Please test |
@swift-ci Please smoke test |
@swift-ci Please Build Toolchain |
@swift-ci please build toolchain |
@swift-ci please test macOS platform |
@swift-ci Please test |
@swift-ci Please smoke test |
@swift-ci please test |
1 similar comment
@swift-ci please test |
@swift-ci Please smoke test |
@swift-ci please build toolchain |
@swift-ci please test |
@swift-ci please smoke test |
@swift-ci please build toolchain |
@swift-ci Please Build Toolchain Linux Platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @talzag!
I think we should get sign-off from @shahmishal or @drewmaxwell-apple on this as well.
@talzag can you briefly summarize the work you did to confirm the issues that caused us to originally disable these tests have been resolved?
Thanks @ethan-kusters. After making sure that DocC tests passed when run both serially and concurrently, I repeatedly ran CI tests (smoke, full, and toolchain). After almost a month, I haven't seen any more issues with DocC tests. I believe that the flakiest tests have all been disabled, and the rest of the tests are now stable and deterministic. |
Ping @shahmishal or @drewmaxwell-apple for a review, too. |
rdar://90181251
This re-enables Swift-DocC tests in toolchain builds.