Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable swift docc tests #41839

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

talzag
Copy link
Contributor

@talzag talzag commented Mar 16, 2022

rdar://90181251

This re-enables Swift-DocC tests in toolchain builds.

@talzag
Copy link
Contributor Author

talzag commented Mar 16, 2022

Please test with following pull request:
swiftlang/swift-docc#101

@swift-ci Please test

@talzag
Copy link
Contributor Author

talzag commented Mar 16, 2022

Please test with following pull request:
swiftlang/swift-docc#101

@swift-ci Please Build Toolchain

@franklinsch
Copy link
Contributor

swiftlang/swift-docc#101
@swift-ci please test

@talzag
Copy link
Contributor Author

talzag commented Mar 16, 2022

swiftlang/swift-docc#101

@swift-ci Please test

@talzag
Copy link
Contributor Author

talzag commented Mar 16, 2022

swiftlang/swift-docc#101

@swift-ci Please Build Toolchain

@talzag
Copy link
Contributor Author

talzag commented Mar 16, 2022

swiftlang/swift-docc#101
@swift-ci Please smoke test macOS platform

@talzag
Copy link
Contributor Author

talzag commented Mar 21, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain macOS Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 21, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain Linux Platform

1 similar comment
@talzag
Copy link
Contributor Author

talzag commented Mar 22, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain Linux Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 23, 2022

swiftlang/swift-docc#101

@swift-ci Please Build Toolchain Linux Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 23, 2022

swiftlang/swift-docc#101

@swift-ci Please Build Toolchain macOS Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 24, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain macOS Platform

3 similar comments
@talzag
Copy link
Contributor Author

talzag commented Mar 24, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain macOS Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 25, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain macOS Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 25, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain macOS Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 25, 2022

swiftlang/swift-docc#101
@swift-ci Please Build Toolchain Linux Platform

@talzag
Copy link
Contributor Author

talzag commented Mar 31, 2022

@swift-ci Please test

@talzag
Copy link
Contributor Author

talzag commented Mar 31, 2022

@swift-ci Please Build Toolchain

@talzag
Copy link
Contributor Author

talzag commented Mar 31, 2022

@swift-ci Please smoke test

@talzag
Copy link
Contributor Author

talzag commented Apr 1, 2022

@swift-ci Please test

@talzag
Copy link
Contributor Author

talzag commented Apr 1, 2022

@swift-ci Please Build Toolchain

@talzag
Copy link
Contributor Author

talzag commented Apr 5, 2022

@swift-ci Please test

@talzag
Copy link
Contributor Author

talzag commented Apr 5, 2022

@swift-ci Please smoke test

@talzag
Copy link
Contributor Author

talzag commented Apr 5, 2022

@swift-ci Please Build Toolchain

@talzag
Copy link
Contributor Author

talzag commented Apr 5, 2022

@swift-ci please build toolchain

@talzag
Copy link
Contributor Author

talzag commented Apr 5, 2022

@swift-ci please test macOS platform

@talzag
Copy link
Contributor Author

talzag commented Apr 6, 2022

@swift-ci Please test

@talzag
Copy link
Contributor Author

talzag commented Apr 6, 2022

@swift-ci Please smoke test

@talzag
Copy link
Contributor Author

talzag commented Apr 7, 2022

@swift-ci please test

1 similar comment
@talzag
Copy link
Contributor Author

talzag commented Apr 7, 2022

@swift-ci please test

@talzag
Copy link
Contributor Author

talzag commented Apr 7, 2022

@swift-ci Please smoke test

@talzag
Copy link
Contributor Author

talzag commented Apr 7, 2022

@swift-ci please build toolchain

@talzag
Copy link
Contributor Author

talzag commented Apr 9, 2022

@swift-ci please test

@talzag
Copy link
Contributor Author

talzag commented Apr 9, 2022

@swift-ci please smoke test

@talzag
Copy link
Contributor Author

talzag commented Apr 9, 2022

@swift-ci please build toolchain

@talzag
Copy link
Contributor Author

talzag commented Apr 12, 2022

@swift-ci Please Build Toolchain Linux Platform

Copy link
Contributor

@ethan-kusters ethan-kusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @talzag!

I think we should get sign-off from @shahmishal or @drewmaxwell-apple on this as well.

@talzag can you briefly summarize the work you did to confirm the issues that caused us to originally disable these tests have been resolved?

@talzag
Copy link
Contributor Author

talzag commented Apr 13, 2022

@talzag can you briefly summarize the work you did to confirm the issues that caused us to originally disable these tests have been resolved?

Thanks @ethan-kusters. After making sure that DocC tests passed when run both serially and concurrently, I repeatedly ran CI tests (smoke, full, and toolchain). After almost a month, I haven't seen any more issues with DocC tests. I believe that the flakiest tests have all been disabled, and the rest of the tests are now stable and deterministic.

@talzag
Copy link
Contributor Author

talzag commented Apr 20, 2022

Ping @shahmishal or @drewmaxwell-apple for a review, too.

@talzag talzag merged commit 09bcbfd into swiftlang:main Apr 21, 2022
@talzag talzag deleted the reenable-swift-docc-tests branch April 21, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants