Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of Windows path API. #472

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix usage of Windows path API. #472

merged 1 commit into from
Apr 26, 2024

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Apr 24, 2024

We must call the API with nil first to get the size of the buffer, then allocate that amount.

This fixes a crash in swift-driver on Windows.

@MaxDesiatov MaxDesiatov requested a review from compnerd April 26, 2024 15:19
compnerd
compnerd approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself seems fine, though I'm not too big a fan of the whitespace changes.

@compnerd
Copy link
Member

@swift-ci please test

@compnerd compnerd enabled auto-merge (rebase) April 26, 2024 15:24
@compnerd compnerd disabled auto-merge April 26, 2024 15:24
@compnerd compnerd enabled auto-merge (squash) April 26, 2024 15:24
@compnerd compnerd merged commit b170d46 into swiftlang:main Apr 26, 2024
3 checks passed
@jeffdav jeffdav deleted the jeff/fix-windows-path-api-usage branch April 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdav @compnerd