Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.10] Fix filesystem test on macOS #461

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[5.10] Fix filesystem test on macOS #461

merged 1 commit into from
Jan 26, 2024

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jan 26, 2024 •
edited
Loading

  • Explanation: It looks like we end up with EEXISTS here on newer versions of macOS.
  • Scope: Any test runs on macOS will fail because of this issue.
  • Risk: Low, it doesn't impact existing file system error handling.
  • Testing: This new file system error case is specifically handled in tests.
  • Reviewer: @neonichu
  • Main branch PR: Fix filesystem test on macOS #460

@neonichu @MaxDesiatov
Fix filesystem test on macOS
2828464 
It looks like we end up with `EEXISTS` here on newer versions of macOS.
@MaxDesiatov MaxDesiatov requested a review from bnbarham January 26, 2024 16:53
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov changed the title Fix filesystem test on macOS [5.10] Fix filesystem test on macOS Jan 26, 2024
@MaxDesiatov MaxDesiatov added the swift 5.10 This PR targets the 5.10 branch label Jan 26, 2024
@MaxDesiatov MaxDesiatov merged commit 2d452ec into main Jan 26, 2024
3 checks passed
@MaxDesiatov MaxDesiatov deleted the fix-tests-on-macos-5.10 branch January 26, 2024 21:41
@finagolfin
Copy link
Member

Merged into wrong branch?

@finagolfin
Copy link
Member

Yep, this commit did nothing, 2d452ec.

@finagolfin
Copy link
Member

Ping @MaxDesiatov, this was merged to the wrong branch, please submit for 5.10.

@MaxDesiatov MaxDesiatov restored the fix-tests-on-macos-5.10 branch February 5, 2024 15:34
@MaxDesiatov MaxDesiatov mentioned this pull request Feb 5, 2024
Merged
@shahmishal shahmishal deleted the fix-tests-on-macos-5.10 branch May 4, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@abertelrud abertelrud Awaiting requested review from abertelrud

@neonichu neonichu Awaiting requested review from neonichu

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
swift 5.10 This PR targets the 5.10 branch test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxDesiatov @finagolfin @airspeedswift @neonichu