-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSystem: make all classes final
to fix Sendable
errors
#406
Conversation
These classes can't be `Sendable` if they aren't final. Somehow it didn't cause CI failures before, but had impact on Swift Driver build jobs.
@swift-ci test |
I wonder if all these need to be classes. do they carry any state? |
I think local filesystem doesn't since it is just a wrapper around other APIs, but the various virtual-ish filesystems need to. |
|
Enabling auto-merge just for the sake of unblocking whatever CI job uncovered this as an error in Swift Driver. |
right, |
@swift-ci test windows |
1 similar comment
@swift-ci test windows |
These classes can't be
Sendable
if they aren't final. Somehow it didn't cause CI failures before, but had impact on Swift Driver build jobs.rdar://108040704