TSCBasic: deprecate localFileSystem setter
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This global should never be mutable, especially when using concurrency. This is also a good opportunity to use `some` instead of `any` existential (the default), since its type is known at compile-time.
MaxDesiatov
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
MaxDesiatov
commented
Mar 15, 2023
|
@swift-ci test |
MaxDesiatov
changed the title
localFileSystem setter, use somelocalFileSystem setter
|
@swift-ci test |
|
@swift-ci test windows |
neonichu
approved these changes
Apr 13, 2023
|
@swift-ci test windows |
tomerd
approved these changes
Apr 14, 2023
tomerd
approved these changes
Apr 14, 2023
Sources/TSCBasic/FileSystem.swift
Outdated
| return _localFileSystem | ||
| } | ||
|
|
||
| @available(*, deprecated, message: "This global should never be mutable and is supposed to be read-only") |
There was a problem hiding this comment.
add a date here in a comment so we know when this was first deprecated and can delete once enough time has passed
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This global should never be mutable, especially when using concurrency.