Make SyntaxArena SPI
#2930
Merged
Make SyntaxArena SPI
#2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
syntax-arena-spi
branch
from
7209b73 to
4579ebf
Compare
Mark `SyntaxArena` and `ParsingSyntaxArena` with `@_spi(RawSyntax)`. `SyntaxArena` and its subclass `ParsingSyntaxArena` were only meant be used when dealing with `RawSyntax` which is already a SPI. Although type type itself was `public`, most initializers were SPI, also there was no way to retrieve it from existing types via public API. So we assume no one was actually using it directly.
rintaro
force-pushed
the
syntax-arena-spi
branch
from
4579ebf to
adc9f33
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Preparation for #2926)
Mark
SyntaxArenaandParsingSyntaxArenawith@_spi(RawSyntax).SyntaxArenaand its subclassParsingSyntaxArenawere only meant be used when dealing withRawSyntaxwhich is already a SPI. Although the type itself waspublic, most initializers were SPI, also there was no way to retrieve it from existing types via public API. So we assume no one was actually using it directly.