[WIP] Tests: Skip failing tests on windows #8210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pipelines do not currently test on windows platform. To get to a point where we can execute tests on windows, we will first disable the failing tests and later enable them as the pipeline is setup to ensure we do not regress in behaviour. related to swiftlang#8121 rdar://139977454
compnerd
reviewed
Jan 21, 2025
| @@ -99,10 +102,13 @@ final class EnvironmentTests: XCTestCase { | |||
|
|
|||
| /// Important: This test is inherently race-prone, if it is proven to be | |||
| /// flaky, it should run in a singled threaded environment/removed entirely. | |||
| func test_current() { | |||
| func test_current() throws { | |||
| try skipOnWindowsAsTestCurrentlyFails(because: "ProcessInfo.processInfo.environment[\"PATH\"] return nil") | |||
There was a problem hiding this comment.
It should return nil as the variable is spelt Path.
There was a problem hiding this comment.
Thank you. The test has been updated to run and pass on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pipelines do not currently test on windows platform. To get to a point where we can execute tests on windows, we will first disable the failing tests and later enable them as the pipeline is setup to ensure we do not regress in behaviour.
related to #8121
rdar://139977454
Motivation:
In preparation for #8176 , disable failing Windows tests.
Modifications:
Mark some tests as Skipped on Windows