Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable new Swift Testing tests #7916

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

bnbarham
Copy link
Contributor

canImport(Testing) currently fails on the full toolchain test jobs due to various issues when building for both x86 and arm64. Temporarily remove this check until we can fix the underlying problems there.

`canImport(Testing)` currently fails on the full toolchain test jobs due
to various issues when building for both x86 and arm64. Temporarily
remove this check until we can fix the underlying problems there.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should put a FIXME in every spot just to make sure that it doesn’t go unnoticed by mistake?

@bnbarham
Copy link
Contributor Author

Maybe we should put a FIXME in every spot just to make sure that it doesn’t go unnoticed by mistake?

Should fix ASAP, I'll add on Monday if we end up not fixing.

@xedin
Copy link
Contributor

xedin commented Aug 25, 2024

Absolutely, that's why I approved :)

@bnbarham bnbarham merged commit 338d5e9 into swiftlang:main Aug 25, 2024
5 checks passed
@bnbarham bnbarham deleted the disable-testing-test branch August 25, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants