Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Avoid use of temp_await in PackageRegistryToolTests.swift" #7169

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Revert "Avoid use of temp_await in PackageRegistryToolTests.swift" #7169

merged 1 commit into from
Dec 8, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Dec 8, 2023

Reverts #7015

@neonichu neonichu self-assigned this Dec 8, 2023
@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2023

@swift-ci please test

@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2023

@swift-ci please test windows

3 similar comments
@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2023

@swift-ci please test windows

@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2023

@swift-ci please test windows

@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2023

@swift-ci please test windows

@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2023

Seems like Windows CI is repeatedly hitting a random issue again:

======UPDATE FAILURES======
C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swift-docc failed (ret=1): ['git', 'rebase', 'FETCH_HEAD']
b'error: cannot rebase: You have unstaged changes.\nerror: Please commit or stash them.\n'
update-checkout failed, fix errors and try again
Build step 'Execute Windows batch command' marked build as failure

@neonichu neonichu mentioned this pull request Dec 8, 2023
Merged
@drexin
Copy link
Contributor

drexin commented Dec 8, 2023

@swift-ci test windows

@tshortli tshortli mentioned this pull request Dec 8, 2023
Merged
@kavon kavon self-requested a review December 8, 2023 05:59
@kavon
Copy link
Member

kavon commented Dec 8, 2023

Merging to unblock CI.

@kavon kavon merged commit 1eb64ab into main Dec 8, 2023
5 checks passed
@kavon kavon deleted the revert-7015-maxd/async-archiver branch December 8, 2023 06:02
@MaxDesiatov

This comment was marked as outdated.

Sign in to view
@MaxDesiatov
Copy link
Contributor

Thanks! Apologies I didn't retrigger CI on the original PR.

MaxDesiatov added a commit that referenced this pull request Dec 11, 2023
@MaxDesiatov
Revert "Revert "Avoid use of temp_await in `PackageRegistryToolTest…
924b612 
…s.swift`" (#7169)"

This reverts commit 1eb64ab.
@MaxDesiatov MaxDesiatov mentioned this pull request Dec 11, 2023
Merged
MaxDesiatov added a commit that referenced this pull request Dec 12, 2023
@MaxDesiatov
Re-revert "Avoid use of temp_await in `PackageRegistryToolTests.swift…
79b7069 
…`" (#7176)

This reverts #7169
with build issues fixed, which itself was a revert of
#7015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavon kavon kavon approved these changes

@tomerd tomerd Awaiting requested review from tomerd

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neonichu @drexin @kavon @MaxDesiatov