Fix Swift SDK bundles not working due to quarantine #6426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Cross-compilation destination" is a very verbose name. "Swift SDK" (note that this is distinct from just plain "SDK" used in other contexts) is a nicer alternative. Not all of the types and functions were renamed yet, especially `Destination`, which has been present in the codebase for long time. Renaming that type will be potentially source-breaking for libSwiftPM clients. This change is focused and updating user-visible strings and renaming types and functions that were only recently added. CLI subcommands were renamed accordingly.
When using `swift experimental-sdk install` subcommand with bundle archives or bundles unpacked from archives downloaded manually in the browser, installed executables are quarantined and trigger an error message when used by `swift build` Steps To Reproduce: 1. Download a destination bundle archive 2. Unpack and install the bundle with `swift experimental-destination install` 3. Confirm that the destination is installed and note its ID with `swift experimental-destination list` 4. Build using the newly installed destination with `swift build --experimental-destination-selector <destination-id>` Actual result: Building with this destination triggers an error: "`swift-driver` cannot be opened because the developer cannot be verified." rdar://107392863
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
neonichu
reviewed
Apr 13, 2023
| #if os(macOS) | ||
| // Remove the quarantine attribute from bundles downloaded manually in the browser. | ||
| let result = try Process.popen( | ||
| arguments: ["xattr", "-d", "-r", "-s", "com.apple.quarantine", installedBundlePath.pathString] |
There was a problem hiding this comment.
Could we use removexattr (or similar) instead of shelling out?
tomerd
approved these changes
Apr 13, 2023
…xd/fix-quarantine-error
…xd/fix-quarantine-error # Conflicts: # Sources/PackageModel/SwiftSDKBundle.swift
|
swiftlang/swift-tools-support-core#414 @swift-ci smoke test |
tomerd
approved these changes
May 10, 2023
tomerd
reviewed
May 10, 2023
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| import Basics | |||
|
|
|||
| import protocol TSCBasic.FileSystem | |||
|
@swift-ci smoke test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci smoke test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
swift experimental-sdk installsubcommand with bundle archives or bundles unpacked from archives downloaded manually in the browser, installed executables are quarantined and trigger an error message when used byswift buildSteps To Reproduce:
swift experimental-destination installswift experimental-destination listswift build --experimental-destination-selector <destination-id>Actual result:
Building with this destination triggers an error: "
swift-drivercannot be opened because the developer cannot be verified."rdar://107392863
Modifications:
We now suggest that users run
xattr -r -d -s com.apple.quarantineon the bundles they trust to remove the quarantine attribute.Result
The error message is clear and actionable.