Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageSigning: mark SigningEntityType as Sendable #6390

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

MaxDesiatov
Copy link
Contributor

This fixes a warning currently triggered when building the PackageSigning target:

PackageSigning/SigningEntity/SigningEntity.swift:19:10: warning: associated value 'recognized(type:name:organizationalUnit:organization:)' of 'Sendable'-conforming enum 'SigningEntity' has non-sendable type 'SigningEntityType'
    case recognized(type: SigningEntityType, name: String, organizationalUnit: String, organization: String)
         ^
PackageSigning/SigningEntity/SigningEntity.swift:79:13: note: consider making enum 'SigningEntityType' conform to the 'Sendable' protocol
public enum SigningEntityType: String, Hashable, Codable {
            ^
                                                        , Sendable

This fixes a warning currently triggered when building the `PackageSigning` target:

```
PackageSigning/SigningEntity/SigningEntity.swift:19:10: warning: associated value 'recognized(type:name:organizationalUnit:organization:)' of 'Sendable'-conforming enum 'SigningEntity' has non-sendable type 'SigningEntityType'
    case recognized(type: SigningEntityType, name: String, organizationalUnit: String, organization: String)
         ^
PackageSigning/SigningEntity/SigningEntity.swift:79:13: note: consider making enum 'SigningEntityType' conform to the 'Sendable' protocol
public enum SigningEntityType: String, Hashable, Codable {
            ^
                                                        , Sendable
```
@MaxDesiatov MaxDesiatov requested a review from abertelrud as a code owner April 5, 2023 14:56
@MaxDesiatov MaxDesiatov self-assigned this Apr 5, 2023
@MaxDesiatov MaxDesiatov requested a review from yim-lee April 5, 2023 14:56
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) April 5, 2023 16:43
@MaxDesiatov MaxDesiatov merged commit 084d46f into main Apr 5, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/sendable-signingentitytype branch April 5, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants