Fix product lookup #6376
Merged
Fix product lookup #6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
commented
Apr 4, 2023
neonichu
commented
Apr 4, 2023
neonichu
force-pushed
the
fix-product-lookup
branch
from
dc1c41f to
3f93267
Compare
|
@swift-ci please smoke test |
do we also need a test to confirm the regression is fixed? |
For module aliasing, we changed the product lookup to include package identity, but product references can use a local identity as specified by the `name` attribute of the package dependency declaration. So for packages where the local `name` attribute didn't match the identity, we would not longer find the corresponding products at all. This switches us back to use the local identity that is also called `explicitNameForTargetDependencyResolutionOnly` in package reference. rdar://106578471
neonichu
force-pushed
the
fix-product-lookup
branch
from
3f93267 to
5c0f55d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
|
Looks like Windows tests can't be started anymore? |
tomerd
approved these changes
Apr 4, 2023
|
@swift-ci please test windows |
|
@shahmishal doesn't seem to be possible anymore to start the Windows build? |
|
Currently the load is high on the Windows system https://ci-external.swift.org/label/windows-server-2019/load-statistics |
|
@shahmishal so we don't have a way to queue these until a node becomes available? |
|
@swift-ci please smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For module aliasing, we changed the product lookup to include package identity, but product references can use a local identity as specified by the
nameattribute of the package dependency declaration. So for packages where the localnameattribute didn't match the identity, we would not longer find the corresponding products at all. This switches us back to use the local identity that is also calledexplicitNameForTargetDependencyResolutionOnlyin package reference.rdar://106578471