Add experimental-destination configuration subcommand
#6252
Conversation
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci smoke test |
|
@swift-ci smoke test |
| @@ -198,7 +198,8 @@ extension ObservabilitySystem { | |||
| public static func swiftTool( | |||
| outputStream: OutputByteStream = stdoutStream, | |||
| logLevel: Basics.Diagnostic.Severity = .warning | |||
| ) -> ObservabilitySystem { | |||
| .init(SwiftToolObservabilityHandler(outputStream: stdoutStream, logLevel: logLevel)) | |||
| ) -> (ObservabilitySystem, SwiftToolObservabilityHandler) { | |||
There was a problem hiding this comment.
This change is needed to allow getting a reference to SwiftToolObservabilityHandler and calling wait(timeout:) on it.
There was a problem hiding this comment.
I think this is fine, but at some point we should consider if these new command should become aligned with the other commands so they dont need this kind of external access
There was a problem hiding this comment.
I found a better way to address that within this PR. Turns out static func swiftTool was used just once in DestinationCommand, it made more sense to move its implementation over there, so there's no need for this tuple-returning function anymore.
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci test windows |
Motivation:
For configuring destination bundles that can't be self-contained and have to reference absolute paths we need new to provide a CLI. This comes as a new
swift experimental-destination configurationsubcommand per the proposed changes in swiftlang/swift-evolution#1942.Modifications:
DestinationCommandprotocol is refined to wait for the observability handler to flush all output. Existing destination-related subcommands are modified to conform to it. Additionally, it now passes a newly initialized observability scope and configuration values.Two new subcommands are added:
configuration showandconfiguration reset. For actually updating configuration values a third subcommandconfiguration setwill be added in a separate PR.Result:
Users can now view and reset destination-related paths configuration.