Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Revert 'Remove --gc-sections for all targets for now (#5708)' #5738

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

finagolfin
Copy link
Member

Cherrypick of #5735

Explanation: lld 13 changed how --gc-sections works last year, which was then flipped on by default, and causes all Swift code on ELF platforms not to link with lld 13 and 14 anymore if stripping is enabled.

Scope: Only affects ELF platforms

SR Issue: #5698 and swiftlang/swift#60406

Risk: low, since it only affects ELF platforms with lld, with nobody else complaining since this was merged six months ago in #4135

Testing: I just built the last August 2 source snapshot of the 5.7 toolchain for Android AArch64, where lld 14 is the default linker, with this flag enabled back then and it worked well.

Reviewer: @keith

This depends on swiftlang/swift#60653 and swiftlang/swift-driver#1158 getting merged first.

@keith
Copy link
Member

keith commented Aug 19, 2022

@swift-ci please smoke test

@tomerd tomerd added the 5.7 label Aug 21, 2022
@tomerd tomerd merged commit 989a078 into swiftlang:release/5.7 Aug 23, 2022
@finagolfin
Copy link
Member Author

@tomerd, the relevant 5.7 driver pulls for lld linked above have not been merged yet, would you ping the relevant 5.7 manager to get them in?

@tomerd
Copy link
Contributor

tomerd commented Aug 23, 2022

sry @buttaface, I will ask, should we revert?

@finagolfin
Copy link
Member Author

Alright, they're in now, this is good.

@finagolfin finagolfin deleted the strip-57 branch August 24, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants