Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LinuxMain.swift to enable automatic test discovery on non-Darwin #532

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Mar 8, 2021

As of swiftlang/swift-package-manager#3053, test discovery is on by default for non-Darwin platforms unless a LinuxMain.swift file is present. If we remove the LinuxMain and XCTTestManifest files, we should be able to adopt it now since swift-driver already more or less requires a nightly toolchain.

@owenv
Copy link
Contributor Author

owenv commented Mar 8, 2021

@swift-ci please test

@owenv
Copy link
Contributor Author

owenv commented Mar 8, 2021

Linux: Executed 218 tests, with 10 tests skipped and 0 failures (0 unexpected) in 19.174 (19.174) seconds
macOS: Executed 218 tests, with 4 tests skipped and 0 failures (0 unexpected) in 49.202 (49.218) seconds

@owenv owenv marked this pull request as ready for review March 8, 2021 01:23
@owenv owenv requested review from porglezomp, artemcm and CodaFi March 8, 2021 01:23
Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@owenv owenv merged commit c753f64 into swiftlang:main Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants