Work around lld 13+ issue with --gc-sections for ELF by adding -z nostart-stop-gc #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
approved these changes
Aug 16, 2022
|
Merging this one since we also merged the other one |
finagolfin
added a commit
to finagolfin/swift-package-manager
that referenced
this pull request
Aug 19, 2022
It should work with lld now that the lld flag '-z nostart-stop-gc' was added with swiftlang/swift#60544 and swiftlang/swift-driver#1153.
neonichu
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Aug 19, 2022
It should work with lld now that the lld flag '-z nostart-stop-gc' was added with swiftlang/swift#60544 and swiftlang/swift-driver#1153.
|
@buttaface This seems to have broken Android CI: https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/1767/consoleFull. Seems like we need to get that CI updated or put in the versioning check here. |
|
@DougGregor, already submitted a pull for the Android CI, swiftlang/swift#60938, just waiting on @drodriguez to update to the latest Android NDK 25b on there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Swift version of swiftlang/swift#60544, which will fix swiftlang/swift#60406. I ran the testsuite on linux x86_64 with this pull without a problem.