Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display concrete examples of the different types of asides #1123

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Dec 9, 2024

Summary

Make it easier to pick which aside to use by showing the types of asides inline in the doc page visually.

Screenshot of the updated doc page

Dependencies

None.

Testing

Build the DocC documentation catalog and preview it.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests (N/A)
  • Ran the ./bin/test script and it succeeded (tests not working on my machine but this should be NFC)
  • Updated documentation if necessary

@j-f1
Copy link
Contributor Author

j-f1 commented Dec 9, 2024

@swift-ci please test

Copy link
Contributor

@d-ronnqvist d-ronnqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-ronnqvist d-ronnqvist merged commit bc67616 into main Dec 10, 2024
2 checks passed
@d-ronnqvist d-ronnqvist deleted the jed/aside-examples branch December 10, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants