-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to disambiguate symbol links using type signature information #1095
Merged
d-ronnqvist
merged 14 commits into
swiftlang:main
from
d-ronnqvist:type-disambiguation-documentation
Dec 10, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
66435cb
Indent table markup for readability
d-ronnqvist 44c0423
Add more details about how relative symbol links works
d-ronnqvist a928b61
Move examples about unambiguous links before "Ambiguous Symbol Links"…
d-ronnqvist 9fcc3cb
Reorder list of supported disambiguation symbol types
d-ronnqvist 42a4cd0
Add missing supported disambiguation symbol types
d-ronnqvist 1d121b7
Move the symbol type disambiguation example above the hash disambigua…
d-ronnqvist 6675b6c
Update `Sloth/update(_:)` example to describe type disambiguation
d-ronnqvist a5bcf42
Add another more complicated type disambiguation example
d-ronnqvist 1489927
Minor refinements to the new documentation
d-ronnqvist c553415
Merge branch 'main' into type-disambiguation-documentation
d-ronnqvist d06d62e
Fix 3 incomplete sentences in the new documentation
d-ronnqvist 840fa93
Add a table of link disambiguation examples
d-ronnqvist 141cef4
Apply suggestions from code review
d-ronnqvist 67e8b14
Merge branch 'main' into type-disambiguation-documentation
d-ronnqvist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't disambiguate the link, why would someone use this suffix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the first few releases of DocC (before Xcode 14.3) DocC required the language identifier prefix for unrelated and uninteresting implementation detail reasons, even though the that information wasn't useful for disambiguation purposes. Links created during those releases continue to work but can be shortened.