Remove unneeded print statements (#101)

* Change CoverageAction to write to given log handle * Remove extraneous print statements from tests rdar://87784021
swiftlang · Mar 29, 2022 · d027bbb · d027bbb
1 parent f1abcfc
commit d027bbb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/Sources/SwiftDocCUtilities/Action/Actions/CoverageAction.swift b/Sources/SwiftDocCUtilities/Action/Actions/CoverageAction.swift
@@ -29,7 +29,8 @@ public struct CoverageAction: Action {
     public mutating func perform(logHandle: LogHandle) throws -> ActionResult {
         switch documentationCoverageOptions.level {
         case .brief, .detailed:
-            Swift.print("   --- Experimental coverage output enabled. ---")
+            var logHandle = logHandle
+            print("   --- Experimental coverage output enabled. ---", to: &logHandle)
 
             let summaryString = try CoverageDataEntry.generateSummary(
                 ofDataAt: workingDirectory.appendingPathComponent(
@@ -38,7 +39,7 @@ public struct CoverageAction: Action {
                 shouldGenerateBrief: true,
                 shouldGenerateDetailed: (documentationCoverageOptions.level == .detailed)
             )
-            print(summaryString)
+            print(summaryString, to: &logHandle)
         case .none:
             break
         }

diff --git a/Tests/SwiftDocCTests/DocumentationService/ConvertService/ConvertServiceTests.swift b/Tests/SwiftDocCTests/DocumentationService/ConvertService/ConvertServiceTests.swift
@@ -835,11 +835,6 @@ class ConvertServiceTests: XCTestCase {
             assert: { renderNodes, referenceStore in
                 let referenceStore = try XCTUnwrap(referenceStore)
                 let paths = Set(referenceStore.topics.keys.map(\.path))
-
-                Set(referenceStore.topics.keys.map(\.path)).forEach { s in
-                    print("path: \(s)")
-                }
-
                 XCTAssertTrue(paths.contains("/documentation/SideKit/SideClass/Element"))
                 XCTAssertFalse(paths.contains("/documentation/SideKit/SideClass/Element/Protocol-Implementations"))
             }

diff --git a/Tests/SwiftDocCTests/Model/DocumentationMarkupTests.swift b/Tests/SwiftDocCTests/Model/DocumentationMarkupTests.swift
@@ -155,7 +155,6 @@ class DocumentationMarkupTests: XCTestCase {
             Text " Abstract."
             """
             let model = DocumentationMarkup(markup: Document(parsing: source, options: .parseBlockDirectives))
-            print(model.abstractSection!.content.map({ $0.detachedFromParent.debugDescription() }).joined(separator: "\n"))
             XCTAssertEqual(expected, model.abstractSection?.content.map({ $0.detachedFromParent.debugDescription() }).joined(separator: "\n"))
         }