Remove dependency on argument-parser #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Ye
force-pushed
the
optimize/tool
branch
from
5f7d7e6 to
35b15ff
Compare
|
@swift-ci please test |
Kyle-Ye
force-pushed
the
optimize/tool
branch
from
35b15ff to
0a9a2db
Compare
ethan-kusters
approved these changes
Sep 25, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits: @ethan-kusters swiftlang/swift-markdown#149
Summary
Removes swift-docc-symbolkit's dependency on swift-argument-parser by refactoring the dump-unified-graph target into its own package.
Dump-unified-graph is largely intended as a tool for developers working on swift-docc-symbolkit so there isn't a need to vend it to clients. Removing argument-parser as a dependency allows for more clients to depend on swift-docc-symbolkit since it removes any potential conflicts with different argument-parser versions.
Testing
Confirm that markdown-tool and swift-markdown continue to build and work as expected.