atomically read page_bitmaps

page_bitmaps does not need to be volatile since it is going to be treated as atomic
swiftlang · Dec 25, 2023 · 823ac37 · 823ac37
1 parent ee39300
commit 823ac37
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/shims/atomic_sfb.h b/src/shims/atomic_sfb.h
@@ -32,7 +32,7 @@
 // Returns UINT_MAX if all the bits in p were already set.
 DISPATCH_ALWAYS_INLINE
 static inline unsigned int
-os_atomic_set_first_bit(volatile unsigned long *p, unsigned int max)
+os_atomic_set_first_bit(unsigned long *p, unsigned int max)
 {
 	unsigned long val, bit;
 	if (max > (sizeof(val) * 8)) {
@@ -82,7 +82,7 @@ os_atomic_set_first_bit(volatile unsigned long *p, unsigned int max)
 
 DISPATCH_ALWAYS_INLINE
 static inline unsigned int
-os_atomic_set_first_bit(volatile unsigned long *p, unsigned int max_index)
+os_atomic_set_first_bit(unsigned long *p, unsigned int max)
 {
 	unsigned int index;
 	unsigned long b, b_masked;
@@ -94,7 +94,7 @@ os_atomic_set_first_bit(volatile unsigned long *p, unsigned int max_index)
 			os_atomic_rmw_loop_give_up(return UINT_MAX);
 		}
 		index--;
-		if (unlikely(index > max_index)) {
+		if (unlikely(index > max)) {
 			os_atomic_rmw_loop_give_up(return UINT_MAX);
 		}
 		b_masked = b | (1UL << index);