Use installed Android cacerts for URLSession #5163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. I've tested it out against the swift-6.0.3-RELEASE-android-24-0.1.artifactbundle.tar.gz artifact from https://github.com/marcprux/swift-android-sdk/actions/runs/12960699464 and loading an https site works on Android. |
marcprux
added a commit
to marcprux/swift-android-sdk
that referenced
this pull request
Jan 25, 2025
marcprux
added a commit
to marcprux/swift-android-sdk
that referenced
this pull request
Jan 25, 2025
* Add swift-android-foundation-cacerts.patch * Update cache key for PR * Update swift-android-foundation-cacerts.patch * Update patch to use CFURLSessionOptionCAPATH instead of CFURLSessionOptionCAINFO * New cache key for github workflow * Fix check for isDirectory * Revert "Fix check for isDirectory" This reverts commit ff12e16. * Revert "Update patch to use CFURLSessionOptionCAPATH instead of CFURLSessionOptionCAINFO" This reverts commit 94e355e. * Go back to using CFURLSessionOptionCAINFO instead of CFURLSessionOptionCAPATH, since the latter does not work * Update patch to match swiftlang/swift-corelibs-foundation#5163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will cause
URLSessionto use the installed Android cacerts folders (/apex/com.android.conscrypt/cacertsand/system/etc/security/cacerts), similar to how swift-nio supports TLS on Android (apple/swift-nio-ssl#453). If no customURLSessionCertificateAuthorityInfoFileenvironment variable is set, it will dynamically assemble a certificate file from the contents of those folders, and then instruct curl to use it with the curl_easy_setopt parameter CURLOPT_CAINFO.This has the benefits of: