Fix open let properties #1595
Merged
Fix open let properties #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
millenomi
suggested changes
Jun 12, 2018
There was a problem hiding this comment.
While it’s incorrect to have open let properties, both open let and public let are wrong here — the interface for these on Darwin is open read only properties.
I think all of these need to be replaced with:
private let _property: Type
open var property: Type { return _property }
to match their Darwin signature.
|
Would |
|
That works as well! |
|
@millenomi updated with spevans suggestion! |
millenomi
approved these changes
Jun 13, 2018
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
'let' properties are implicitly 'final'; use 'public' instead of 'open'warnings