-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic CSV views #76
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 92.57% 91.74% -0.84%
==========================================
Files 14 13 -1
Lines 431 424 -7
==========================================
- Hits 399 389 -10
- Misses 32 35 +3
Continue to review full report at Codecov.
|
be46ff3
to
c5738a9
Compare
Hmm I haven't had anyone else review this code yet; @lukestringer90 with your real-world application of SwiftCSV, what do you think about the separation of the numbered/named access to CSV from this branch? |
@DivineDominion I'll try and take a look for you when I'm next working on my project. Where is the best place to start looking to understand the changes you've made here? |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 92.53% 93.70% +1.17%
==========================================
Files 14 14
Lines 402 445 +43
==========================================
+ Hits 372 417 +45
+ Misses 30 28 -2
Continue to review full report at Codecov.
|
@lukestringer90 I updated the PR to incorporate the v0.5.6 changes. Offers ways to interact with a CSV via enumeration and also via key/value-like access. The tests should be indicative what's going on behind the scenes. It's mostly a refactoring of the old code that used to mix things up but then errored-out when you used the wrong combination of initial configuration and subsequent data access. The main question I have is: does this improve the clarity of use and the overall features of the library? Is this a good, or e.g. an over-engineered way forward? |
2badb26
to
435e558
Compare
CSV previously sported multiple variants and ways to access data that were supposed to be mutually exclusive. With this change, it now really is, ensured by the compiler.