Force non-passive event for touch device #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Touch event listeners had a breaking change in chrome 56. Passive events became the default in Chrome 56 and up. This PR's forces the listener to be non-passive, so that `preventDefault` is no longer being ignored. Without it, the page wants to navigate to the next / previous page when swiping on a touch screen. See: https://developers.google.com/web/updates/2017/01/scrolling-intervention Related: facebook/react/#8968
|
Should i add this to other touch event handlers? |
|
@wangzuo , that will prevent some warnings in the console. So you can do that. This fix is purely to fix the navigation issue. Chrome want's to browse to the previous page when swiping to the right. So a time-change triggered the navigation. More correct way of fixing those warnings; is to not |
|
Keep this open due to the react-dom warning facebook/react#8968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touch event listeners had a breaking change in chrome 56. Passive events became the default in Chrome 56 and up. This PR's forces the listener to be non-passive, so that
preventDefaultis no longer being ignored. Without it, the page wants to navigate to the next / previous page when swiping on a touch screen.See: https://developers.google.com/web/updates/2017/01/scrolling-intervention
Related: facebook/react/#8968