Fix for Issue #57: Attempt to change hex code by typing results in #2NanNanNan #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #57. Changes the behaviour for the hex input so that the hex value will only change if the user tabs away from the input or if the user presses the enter key.
Added a local
hexInputstate that stores the input value for the hex text input.hexInputvalue also gets updated in a useEffect hook whenever the parent hex value changes.Updating the parent hex value is moved to onBlur and OnKeyUp. A regex check was added to
changeHexto ensurechangeColoris only called if the hex value is valid.