Minor cleanup #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused variables, clean up indentation, fix / add some comments, remove some commented-out old lines of code. The one change that actually changes any code is moving the calculations of fsds_vis_d and fsds_nir_d a few lines down, back to where they used to be, to keep them next to the related variables. From a read of the surrounding code, this move looks safe.
swensosc
pushed a commit
that referenced
this pull request
Mar 7, 2025
Merge up to ctsm5.2.006 and deconflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variables, clean up indentation, fix / add some comments,
remove some commented-out old lines of code.
The one change that actually changes any code is moving the calculations
of fsds_vis_d and fsds_nir_d a few lines down, back to where they used
to be, to keep them next to the related variables. From a read of the
surrounding code, this move looks safe.