-
-
Notifications
You must be signed in to change notification settings - Fork 265
Web page for Oxford DTC bootcamp and markdown parsing fix #97
Conversation
@apawlik - did you check that the change to the default parser in _config.yml didn't break anything? We should probably let pull requests with big changes like this sit open for a little bit longer before merging them in. Looking at the history of @jonc125's commit, this is a suggested fix for getting github pages working due to an existing bug in maruku, the default MarkDown parser for Hyde (which generates the pages). I don't know anything about maruku vs. rdiscount as a Markdown parser, but global changes like this should not be made arbitrarily. |
@wking - I don't know the best way to back this out. The change to _config.yml is in this commit: jonc125@97d06f4 Backing it out will certainly break the oxford-dtc page, but I think that's better than a global unreviewed change to our Markdown parser. |
git-revert is probably the easiest way to back out that commit, although given it wasn't too tidy you might be better off just deleting the offending line from _config.yml until it's been checked on other pages. |
@jonc125 - Exactly. They do different things to our git history, though, and until Trevor or another git expert is up, I'd prefer to avoid making more changes into master. @apawlik - This is a very minor issue, so don't sweat it. We're bound to merge in unwanted changes accidentally in the future, and I'd like to take this as an opportunity to have Trevor or another expert walk us through the right procedure for backing them out in the most recommended way. |
On Tue, May 14, 2013 at 07:07:45AM -0700, ahmadia wrote:
I think opinions will differ here ;). My favorite choices would be: a. Revert the merge and force push to gh-pages. Since the merge has been only been public for an hour, I'm leaning |
@wking - I am okay with fixing gh-pages with a force-push. Do you want me On Tue, May 14, 2013 at 3:12 PM, W. Trevor King [email protected]:
|
On Tue, May 14, 2013 at 07:14:30AM -0700, ahmadia wrote:
Go ahead. |
@ahmadia Well, today it may be a minor issue but tomorrow I'm going to trash the whole SWC (touch wood). I certainly would like to learn how to recover from situations like this so it's a good lesson (although I didn't intend to make it happen). Thanks for resolving the problem. |
@wking - The boot camp attendees would need a time machine to see it before On Tue, May 14, 2013 at 3:21 PM, W. Trevor King [email protected]:
|
There's no rush for this - I was pointing people at my own page as @ahmadia says! I'll see if I can set up the separate PR shortly. |
On Tue, May 14, 2013 at 07:17:42AM -0700, Aleksandra Pawlik wrote:
You have more leeway when it's a boot-camp-specific branch ;). We
You can usually use $ git merge wking/terrible-branch # Oops! It's important to think that sort of thing through though, since it's Good reading: https://www.kernel.org/pub/software/scm/git/docs/user-manual.html#cleaning-up-history |
Okay, the commit has been rewound. Thanks for your help Trevor.
@jonc125 - It sounds like you've got a plan for putting this pull request back together. Feel free to ping me if you have any questions I can answer. |
Changed GitHub URLs from SSH to HTTPS
Convert "teach python" to "best practices"
As well as the page with our installation instructions etc., this also adds a setting to _config.yml which changes the Markdown parser to use, as the default parser doesn't handle nested lists properly.