Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python inflammation: Episode 1, "Python Fundamentals" #149

Open
wants to merge 2 commits into
base: ja
Choose a base branch
from

Conversation

masamiy
Copy link
Collaborator

@masamiy masamiy commented Feb 4, 2021

Hello editors and maintainers!
I followed your guidance and got up to here. While I see many red 'x' next to file names, at least I see my translation in python-inflammation po file. Let's hope I am doing right!
Thank you for your love and care,
Masami

@joelnitta
Copy link
Member

Thanks! This looks fine, I think you did a great job! 👍
I just realized that we don't have issues open for the python episodes yet, so you're ahead of me. I'll try to do that soon.
It looks like this is a translation of intro.md, correct?

@masamiy
Copy link
Collaborator Author

masamiy commented Feb 4, 2021

Thanks! This looks fine, I think you did a great job! 👍

Thanks! I hope I really did :)

It looks like this is a translation of intro.md, correct?

I think so... I translated "Python Fundamentals". I am working on a long (possibly original?) po file. You may have expected po files are splitted?

@joelnitta joelnitta changed the title Python inflammation Python inflammation: Episode 1, "Python Fundamentals" Feb 4, 2021
@joelnitta
Copy link
Member

No, the splitting of PO files has not been merged yet. So you're good to work on the one large PO file.

If you could please just translate 1 episode at a time (like you've done here) and indicate the episode name in the title of your pull request, that would be great (I went ahead and changed it here for you).

@masamiy
Copy link
Collaborator Author

masamiy commented Feb 5, 2021

Thanks! I follow that from now on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants