Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of Git episode 8 #147

Open
wants to merge 37 commits into
base: ja
Choose a base branch
from
Open

Translation of Git episode 8 #147

wants to merge 37 commits into from
+91 −105

Conversation

kozo2
Copy link
Collaborator

@kozo2 kozo2 commented Jan 24, 2021 •
edited
Loading

See also #68

@TomKellyGenetics TomKellyGenetics linked an issue Feb 2, 2021 that may be closed by this pull request
Translation: git-novice Episode 8 #68
Open
@joelnitta joelnitta self-requested a review August 2, 2021 06:11
joelnitta
joelnitta reviewed Aug 8, 2021
View reviewed changes
Copy link
Member

@joelnitta joelnitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see my comments and suggestions.

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
kozo2 and others added 14 commits August 9, 2021 18:06
@kozo2 @joelnitta
Update po/git-novice.ja.po
67d111e 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
3ed7b5f 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
0738ae6 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
315b2eb 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
2c7bdfe 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
2baf995 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
0cb4ae9 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
c8697ec 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
70037d7 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
5aed9b5 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
8588906 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2 @joelnitta
Update po/git-novice.ja.po
283c730 
Co-authored-by: Joel Nitta <[email protected]>
@kozo2
Update git-novice.ja.po
7ab0e59
@kozo2
Update git-novice.ja.po
8d7bb45
@kozo2
Copy link
Collaborator Author

kozo2 commented Aug 14, 2021

@joelnitta
I have committed all your suggestions other than
#147 (comment)

joelnitta
joelnitta approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@joelnitta joelnitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joelnitta joelnitta requested a review from masamiy October 3, 2021 00:36
masamiy
masamiy requested changes Oct 3, 2021
View reviewed changes
Copy link
Collaborator

@masamiy masamiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kozo for your work!
I made a few suggestions, but they are suggestions only.
I understand that we insert a half space between alphabet and Japanese. Most of my suggestions are related to this.

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
kozo2 and others added 17 commits December 1, 2021 00:26
@kozo2 @masamiy
Update po/git-novice.ja.po
67bbcac 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
bec5313 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
baca4c3 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
53ca41c 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
13bde97 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
da173be 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
76514a0 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
ebfbcb1 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
5798024 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
202bb1c 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
9c020f3 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
9074fe9 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
27bbe2d 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
13dcf91 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
b9454c5 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
ab802cf 
Co-authored-by: masamiy <[email protected]>
@kozo2 @masamiy
Update po/git-novice.ja.po
2e4c9b0 
Co-authored-by: masamiy <[email protected]>
@kozo2
Copy link
Collaborator Author

kozo2 commented Dec 1, 2021

Thanks @masamiy for your suggestions!
I committed all your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masamiy masamiy masamiy requested changes

@joelnitta joelnitta joelnitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation: git-novice Episode 8
3 participants
@kozo2 @joelnitta @masamiy