-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation of Git episode 2 #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation! I just have a few comments/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! My comments are really only suggestions.
Co-authored-by: masamiy <[email protected]> Co-authored-by: Joel Nitta <[email protected]>
I have added everyone's suggestions, so I think this should be good for merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Riku, let's see if we can trigger GitHub Actions: https://github.com/swcarpentry-ja/i18n/actions?query=workflow%3ARender-Webpages
Had to mess with the script and formatting but now it's builds webpages automatically when a commit is pushed to Page updated by bot: GitHub Actions instance (runs 3 lessons simultaneously). Long story on how to give it permissions and make it run in an empty docker container should work like magic from now on. |
Translation of Git episode 2.
I had a minor merge conflict when pulling from the
swcarpentry-ja/i18n ja
branch, so something might be a bit "off".よろしくおねがいします:slightly_smiling_face: