Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of Git episode 2 #107

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Conversation

rikutakei
Copy link
Collaborator

Translation of Git episode 2.

I had a minor merge conflict when pulling from the swcarpentry-ja/i18n ja branch, so something might be a bit "off".

よろしくおねがいします:slightly_smiling_face:

@rikutakei rikutakei linked an issue Aug 2, 2020 that may be closed by this pull request
@joelnitta joelnitta self-assigned this Aug 14, 2020
Copy link
Member

@joelnitta joelnitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation! I just have a few comments/suggestions.

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@masamiy masamiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! My comments are really only suggestions.

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Show resolved Hide resolved
po/git-novice.ja.po Show resolved Hide resolved
po/git-novice.ja.po Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
@rikutakei
Copy link
Collaborator Author

I have added everyone's suggestions, so I think this should be good for merging

@TomKellyGenetics TomKellyGenetics self-requested a review November 10, 2020 18:11
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
Copy link
Member

@TomKellyGenetics TomKellyGenetics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Riku, let's see if we can trigger GitHub Actions: https://github.com/swcarpentry-ja/i18n/actions?query=workflow%3ARender-Webpages

@mergify mergify bot merged commit 8227e94 into swcarpentry-ja:ja Nov 10, 2020
@TomKellyGenetics
Copy link
Member

TomKellyGenetics commented Nov 11, 2020

Had to mess with the script and formatting but now it's builds webpages automatically when a commit is pushed to ja branch. This includes PRs after they're merged.

Page updated by bot:
https://swcarpentry-ja.github.io/git-novice/ja/_episodes/02-setup/index.html

GitHub Actions instance (runs 3 lessons simultaneously).
https://github.com/swcarpentry-ja/i18n/actions/runs/357290157

Long story on how to give it permissions and make it run in an empty docker container should work like magic from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation: git-novice Episode 2
4 participants