Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributions cannot be made directly to the translated lessons but the files instruct users to do so #12

Open
TomKellyGenetics opened this issue Nov 2, 2018 · 2 comments
Open

Contributions cannot be made directly to the translated lessons but the files instruct users to do so #12

TomKellyGenetics opened this issue Nov 2, 2018 · 2 comments

Comments

@TomKellyGenetics
Copy link
Member

The English version assumes that contributions can be made directly to the lesson repo. If the translation is a mirror of the current English lesson, we should instead instruct users to send a PR to the English lesson to request changes (if they can in English) or raise an issue in the local language to suggest a change to the English and localised lessons. #11

Perhaps we need to make changes to the Japanese Contributions.md to make this clear, in line with #5.
@TomKellyGenetics TomKellyGenetics mentioned this issue Nov 2, 2018
Merged
TomKellyGenetics added a commit that referenced this issue Nov 10, 2018
@TomKellyGenetics
add explanation to README and format guides #5 #6 #8 #11 #12 #14
db8583c
@TomKellyGenetics TomKellyGenetics mentioned this issue Nov 10, 2018
Closed
@TomKellyGenetics
Copy link
Member Author

Further detail on how to contribute to translated lessons has been added to the README

joelnitta pushed a commit to joelnitta/i18n that referenced this issue Nov 21, 2020
@dpshelio
Merge pull request swcarpentry-ja#12 from carpentries-i18n/helpers
48b3009 
Helpers script for maintenance
@TomKellyGenetics
Copy link
Member Author

This could be taken care of my directing people to the i18n repo or a translation handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomKellyGenetics