Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/generator): Fix code generation for break in nested while #9684

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

CPunisher
Copy link
Contributor

Description:

BREAKING CHANGE:

Related issue (if exists):

closes #9110

@CPunisher CPunisher requested a review from a team as a code owner October 29, 2024 06:57
Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 0876eb4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #9684 will improve performances by 7.29%

Comparing CPunisher:fix/generator-break (0876eb4) with main (7aab945)

Summary

⚡ 1 improvements
✅ 193 untouched benchmarks

Benchmarks breakdown

Benchmark main CPunisher:fix/generator-break Change
es/full/bugs-1 562.6 µs 524.4 µs +7.29%

kdy1
kdy1 previously approved these changes Oct 29, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! How did you investigate it? Actually I couldn't find a good way to investigate generator pass issues

@kdy1 kdy1 requested a review from a team as a code owner October 29, 2024 13:20
@kdy1 kdy1 merged commit 65872af into swc-project:main Oct 29, 2024
22 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.41 Oct 29, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@swc/helper _ts_generator wrong code exported
2 participants