Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/testing): Revert #9264 #9621

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix(es/testing): Revert #9264 #9621

merged 2 commits into from
Oct 8, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 8, 2024

Reverts #9264

@kdy1 kdy1 added this to the Planned milestone Oct 8, 2024
@kdy1 kdy1 self-assigned this Oct 8, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 8, 2024 03:26
Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 5f6abb8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 8, 2024
@kdy1 kdy1 changed the title Revert "feat(es/testing): Parse test code as a Program instead of a Module" fix(es/testing): Revert #9264 Oct 8, 2024
@kdy1 kdy1 merged commit 85f5e5b into main Oct 8, 2024
5 checks passed
@kdy1 kdy1 deleted the revert-9264-issue-8713 branch October 8, 2024 03:27
@kdy1 kdy1 modified the milestones: Planned, v1.7.31 Oct 8, 2024
Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #9621 will improve performances by 3.4%

Comparing revert-9264-issue-8713 (5f6abb8) with main (85f5e5b)

Summary

⚡ 1 improvements
✅ 193 untouched benchmarks

Benchmarks breakdown

Benchmark main revert-9264-issue-8713 Change
es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=false 1.3 ms 1.2 ms +3.4%

@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant