Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Ensure decorators are emitted first in TS paramters #9545

Merged
merged 4 commits into from
Sep 11, 2024
Merged

fix(es/codegen): Ensure decorators are emitted first in TS paramters #9545

merged 4 commits into from
Sep 11, 2024
+20 −6

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Sep 10, 2024 •
edited by kdy1
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9a1129

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@magic-akari magic-akari marked this pull request as ready for review September 10, 2024 16:48
@magic-akari magic-akari requested a review from a team as a code owner September 10, 2024 16:48
@kdy1 kdy1 added this to the Planned milestone Sep 10, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9545 will improve performances by 3.56%

Comparing magic-akari:fix/issue-9543 (d9a1129) with main (8b1e442)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9543 Change
⚡ es/visitor/base-perf/boxing_unboxed_clone 2.5 µs 2.5 µs +3.56%

@kdy1 kdy1 enabled auto-merge (squash) September 11, 2024 02:00
@kdy1 kdy1 disabled auto-merge September 11, 2024 02:47
@kdy1 kdy1 merged commit 47ef38d into swc-project:main Sep 11, 2024
152 of 153 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.25 Sep 11, 2024
@magic-akari magic-akari deleted the fix/issue-9543 branch September 12, 2024 08:29
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
S-approved
Milestone
v1.7.25
Development

Successfully merging this pull request may close these issues.

@swc/core modified the declaration order of protected and private, resulting in syntax errors
2 participants
@magic-akari @kdy1