Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Handle minify number #9541

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

magic-akari
Copy link
Member

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: bebec07

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Sep 10, 2024

CodSpeed Performance Report

Merging #9541 will improve performances by 5.26%

Comparing magic-akari:fix/issue-9540 (21ed602) with main (f63a481)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9540 Change
es/full/bugs-1 550.6 µs 523.1 µs +5.26%

@magic-akari magic-akari force-pushed the fix/issue-9540 branch 2 times, most recently from 0f06e95 to 981ebb5 Compare September 10, 2024 15:20
@magic-akari magic-akari marked this pull request as ready for review September 10, 2024 16:45
@magic-akari magic-akari requested review from a team as code owners September 10, 2024 16:45
@kdy1 kdy1 added this to the Planned milestone Sep 11, 2024
@kdy1 kdy1 requested a review from a team as a code owner September 11, 2024 01:56
@kdy1 kdy1 enabled auto-merge (squash) September 11, 2024 01:58
@kdy1 kdy1 disabled auto-merge September 11, 2024 02:20
@kdy1 kdy1 merged commit 8b1e442 into swc-project:main Sep 11, 2024
152 of 153 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.25 Sep 11, 2024
@magic-akari magic-akari deleted the fix/issue-9540 branch September 12, 2024 08:29
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Number compression with minification creates invalid code
2 participants