Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore tests fixed by #1264 #9088

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yacinehmito
Copy link

Description:

Unignored the tests in swc_bundler that were ignored pending the merge of #1264.

The tests deno_8481_1 and deno_8188_full have been merged into one because they run the same code. Although they tracked two different regressions, the assertion was the same. The URL has been changed in order to avoid pointing directly on master.

Related issue (if exists): #1264

@yacinehmito yacinehmito requested a review from a team as a code owner June 21, 2024 07:07
@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this?

@yacinehmito
Copy link
Author

I just saw the ignored tests but that the issue was closed. If you prefer I can remove the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants