fix(es/parser): Fix parsing of dynamic source phase imports #8611
+54
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dsherret
commented
Feb 6, 2024
| tok!("import") => { | ||
| let import = self.parse_ident_name()?; | ||
|
|
||
| if is!(self, '.') { |
There was a problem hiding this comment.
This was a red herring and didn't work. For example, this does is!(self, '.') then expect!(self, '.') below.
kdy1
changed the title
magic-akari
approved these changes
Feb 6, 2024
swc-bot
reviewed
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes parsing of dynamic source phase imports.
BREAKING CHANGE:
Related issue (if exists):