fix(es/resolver): Ignore qualifiers of TsImportType
#8299
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 17, 2023
| @@ -0,0 +1,4 @@ | |||
| import { MyClass__2 } from "./MyClass.ts"; | |||
| const test__2 = new MyClass__2(); | |||
| export type MyType__2 = import("./deps.ts").MyClass__0; | |||
There was a problem hiding this comment.
This was previously:
export type MyType__2 = import("./deps.ts").MyClass__2;
|
CI failures seem unrelated. |
kdy1
approved these changes
Nov 17, 2023
kdy1
changed the title
TsImportType
swc-bot
reviewed
Nov 18, 2023
swc-bot
reviewed
Nov 18, 2023
|
CI failures seem due to actions/setup-node#899 |
swc-bot
reviewed
Nov 19, 2023
swc-bot
reviewed
Nov 19, 2023
swc-bot
reviewed
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The
Resolverwas resolving the qualifier ofTsImportTypeRelated issue (if exists): None