fix(es/typescript): Support ts_enum_is_mutable with const enums
#8171
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Oct 23, 2023
| @@ -4581,5 +4586,7 @@ test!( | |||
| })(D || (D = {})); | |||
| D.A = 5; | |||
| console.log(D.A); | |||
| var E; | |||
There was a problem hiding this comment.
Improvement for swc in the future might be to not emit this for const enums.
kdy1
previously approved these changes
Oct 23, 2023
enum Foo {
A = 2
}
const enum Bar {
B = Foo.A
}
console.log(Bar.B)Could you add this test case? |
dsherret
commented
Oct 23, 2023
| (function(I) { | ||
| I[I["A"] = H.A] = "A"; | ||
| })(I || (I = {})); | ||
| console.log(I.A); |
There was a problem hiding this comment.
This is not ideal, but it's ok output. It's a rare edge case for someone to use an enum in a const enum.
|
@magic-akari good idea! I added a test for that and for the opposite. |
kdy1
approved these changes
Oct 23, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Bug I introduced in https://github.com/swc-project/swc/pull/8115/files (it was not implemented correctly)