Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): Fix logic for excluding FileName from source maps #7900

Merged
merged 14 commits into from
Aug 31, 2023
Merged

fix(common): Fix logic for excluding FileName from source maps #7900

merged 14 commits into from
Aug 31, 2023
+133 −10

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 31, 2023 •
edited
Loading

Description:

This PR also modifies React transform to use FileName::Internal and makes SourceMapGenConfig skips FileName::Internal.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Aug 31, 2023
@kdy1 kdy1 self-assigned this Aug 31, 2023
@kdy1 kdy1 changed the title fix(es/compat): Exclude <<jsx-config-pragma.js>> from output source maps fix(common): Fix excluding logic for FileName Aug 31, 2023
@kdy1 kdy1 changed the title fix(common): Fix excluding logic for FileName fix(common): Fix logic for excluding FileName from source maps Aug 31, 2023
@kdy1 kdy1 marked this pull request as ready for review August 31, 2023 06:06
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 31, 2023
View reviewed changes
kdy1
kdy1 commented Aug 31, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 31, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) August 31, 2023 06:08
@kdy1 kdy1 mentioned this pull request Aug 31, 2023
Open
swc-bot
swc-bot reviewed Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 31, 2023
View reviewed changes
swc-bot
swc-bot reviewed Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit aa64955 into swc-project:main Aug 31, 2023
@kdy1 kdy1 deleted the issue-5272 branch August 31, 2023 13:23
@kdy1 kdy1 modified the milestones: Planned, v1.3.82 Sep 1, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.82
Development

Successfully merging this pull request may close these issues.

Coverage reports include <<jsx-config-pragma.js>>, causing errors
2 participants
@kdy1 @swc-bot