Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/typescript): Support export type * from "mod" #6867

Merged
merged 5 commits into from
Feb 28, 2023
Merged

feat(es/typescript): Support export type * from "mod" #6867

merged 5 commits into from
Feb 28, 2023

Conversation

magic-akari
Copy link
Member

Description:

Adds support for export type * from "mod" and export type * as ns from "mod".

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review January 28, 2023 07:41
@kdy1 kdy1 self-assigned this Jan 28, 2023
@kdy1 kdy1 added this to the Planned milestone Jan 28, 2023
@kdy1
Copy link
Member

kdy1 commented Jan 30, 2023

I'll review/merge this once 5.0 is published, as this will break Wasm plugins

kdy1
kdy1 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) February 28, 2023 04:48
swc-bot
swc-bot reviewed Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment •
edited by kdy1
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit beb38d3 into swc-project:main Feb 28, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.38 Mar 6, 2023
@magic-akari magic-akari deleted the feat/export-type-star branch March 10, 2023 02:51
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.38
Development

Successfully merging this pull request may close these issues.
3 participants
@magic-akari @kdy1 @swc-bot