Fix TS types for AST nodes #5175
Merged
+333
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, the types are now correct, but their usage in |
|
I've made changes to There are likely a lot of inaccuracies remaining in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes various inaccuracies in the TS type definitions for AST nodes. They seem to have got out of sync over time.
These discrepancies were identified programmatically based on the model of the Rust types I've made for #2175. So this PR should be definitive and bring the TS types completely up to date.
NB Some of the changes just re-order fields and enum options. This doesn't make a difference to correctness of the types. But now they're all consistent with field order in the Rust types, which will maybe make it easier to spot when further changes are required in future.
Related issue (if exists):
n/a