Make rls work #30
Merged
Make rls work #30
+113
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-analysis chokes with `Option<Box<Expr>>` style fields. Rls only shows a warning on the crate with that fields, but ICEs on dependent crates. This can be workarounded by using `Option<(Box<Expr>)>`. Also, using multiple glob imports is bad for rls. So this commit deglobs them.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2018
30: Make rls work r=kdy1 a=kdy1 rust-analysis chokes with `Option<Box<Expr>>` style fields. Rls only shows a warning on the crate with that fields, but ICEs on dependent crates. This can be workarounded by using `Option<(Box<Expr>)>`. Also, using multiple glob imports is bad for rls. So this commit deglobs them.
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analysis chokes with
Option<Box<Expr>>style fields.Rls only shows a warning on the crate with that fields, but ICEs on
dependent crates.
This can be workarounded by using
Option<(Box<Expr>)>.Also, using multiple glob imports is bad for rls.
So this commit deglobs them.