chore(atoms): Evaluate .into() in AtomStoreCell eagerly (#8363)

**Related issue:** - Closes #8362
swc-project · Dec 1, 2023 · 1e8edb4 · 1e8edb4
1 parent d0a885d
commit 1e8edb4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/crates/swc_atoms/src/lib.rs b/crates/swc_atoms/src/lib.rs
@@ -238,6 +238,8 @@ pub struct AtomStoreCell(UnsafeCell<AtomStore>);
 impl AtomStoreCell {
     #[inline]
     pub fn atom<'a>(&self, s: impl Into<Cow<'a, str>>) -> Atom {
+        // evaluate the into before borrowing (see #8362)
+        let s: Cow<'a, str> = s.into();
         // SAFETY: We can skip the borrow check of RefCell because
         // this API enforces a safe contract. It is slightly faster
         // to use an UnsafeCell. Note the borrow here is short lived