This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
seat: avoid copying the keymap for each client #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH, I wonder if we even need |
|
I don't see anything mentioned, so let's do it unconditionally. Worst case we discover a faulty protocol assumption. :) |
This function behaves like allocate_shm_file, except it also returns a read-only FD. This is useful to share the same segment of memory with many Wayland clients.
This exposes a read-only FD with the keymap.
We can just send a read-only file descriptor instead.
|
Updated to always send a read-only FD. Tested with a few clients (GTK, Qt, foot, alacritty, etc), all seem to work fine. Also opened https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/176 to make the spec clearer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client supports wl_keyboard version 7, no need to allocate
and copy a new keymap file. We can use a read-only file instead.