Update to depend on lsp-2.4.0.0
#1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #1350. This is a giant pain in the butt. Lots of names, function signatures, etc. changed and there doesn't seem to be any documentation/migration guide explaining how to update.
No idea if it actually works, probably not
Co-authored-by: Restyled.io <[email protected]>
kostmo
approved these changes
Feb 12, 2024
|
@kostmo No worries, thanks! Everything I've tried seems to work, so I'll merge and of course we can open an issue if you discover any regressions later. |
|
Have to merge manually since the mergify configuration changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use the
lsp-2.4API. Closes #1350.Initially I hoped that any
lsp-2.xwould work. However, theSeverDefinitionrecord changed in2.2so I initially set that as a lower bound. But then it turns out that2.4changed which module it is importingRopefrom; since we work with ropes in theHovermodule it matters since we have to import the matching module. Updating to the newRopetype also required some changes as the API provided by the newRope.Mixedmodule is a bit different than the old module, so we would not even be able to easily put in CPP to conditionally depend on the right rope module depending on thelspversion. Finally, this means dropping support for GHC 9.0 sincelsp-2.4does not support it.Along the way I also fixed a minor issue related to showing type information returned by the LSP server, so that it uses
prettyTypeLineto display the type on a single line (in my editor, when the type does not use a single line it gets cut off). For comparison see also #1610.This refactoring was a big pain because a lot of things (names of types and constructors, locations of exports, etc...) changed from 1.x to 2.x, but there was not much in the way of documenting what had changed. =( I am pretty sure that all functionality has been preserved but I would appreciate independent confirmation.
This is also a prerequisite for updating other dependencies such as the
baseversion (I will open a follow-up PR soon) since the oldlsp-1.xversions do not allow many newer versions of various dependencies.