Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the stack build #1627

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix the stack build #1627

merged 1 commit into from
Nov 15, 2023

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Nov 15, 2023

Closes #1624.

Note, however, that currently (until #1623) this will not work on Windows, since I explicitly added vty-unix as an extra-dep in the stack.yaml file. However, I expect we will get #1623 soon and then we can remove it.

@byorgey
fix the stack build
5dee9b4 
Closes #1624.

Note, however, that currently (until #1623) this will not work on
Windows, since I explicitly added `vty-unix` as an `extra-dep` in the
`stack.yaml` file.  However, I expect we will get #1623 soon and then
we can remove it.
@kostmo kostmo self-requested a review November 15, 2023 03:18
kostmo
kostmo approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@kostmo kostmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine.

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Nov 15, 2023
@mergify mergify bot merged commit 8f52e53 into main Nov 15, 2023
@mergify mergify bot deleted the fix/stack-build branch November 15, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix or deprecate stack build
2 participants
@byorgey @kostmo